Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new definitions for types in Tribol. The changes are as follows:
tribol::integer
in favor ofint
, or other C++ fundamental types as dictated by the specific variable (e.g.unsigned short
might make more sense for a variable that represents spatial dimension)tribol::IndexT
asaxom::IndexType
for indexing into axom types (e.g.axom::Array
). Note the use oftribol::IndexT
still needs to be checked in source files. This will be done in future PRs.tribol::real
astribol::RealT
and ensure proper usage throughout source files.tribol::RealT
is defined as adouble
; if the user attempts to map it tofloat
by definingTRIBOL_USE_SINGLE_PRECISION
, an error will occur since Tribol has not been tested with single precision.tribol::containerArray
astribol::ArrayT
and define it as anaxom::Array
(with template arguments) instead ofstd::vector
tribol::CommType
totribol::CommT
to be consistent with other Tribol type namesNote, this PR does not address types in redecomp or in the Fortran/C interface.